Add basic documentation on what is and isn't checked by template check
#4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
a6fcb7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3644f9c9.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-doc-templatecheck1.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Admin-API
sandhose
reviewed
Oct 27, 2025
|
|
||
| What is not checked: | ||
| - the validity of the generated HTML (you can forget closing tags, or otherwise create invalid HTML output) | ||
| - undefined variables (`{{ undefined_variable }}` will render as an empty string and not raise an error) |
There was a problem hiding this comment.
You're changing that though, right?
| ``` | ||
|
|
||
| What is checked: | ||
| - the Jinja templates are syntactically valid |
There was a problem hiding this comment.
And that they can render with a few sample values (but not all combinations?)
|
Supplanted by #5214 which includes this documentation, updated and some more documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.